[wasm] Include data archives and timezone data by default #39586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lewing
changed the title
kg
reviewed
Jul 18, 2020
| bytes, true /* canRead */, true /* canWrite */, true /* canOwn */ | ||
| ); | ||
|
|
||
| if (!this.mono_wasm_load_data_archive (bytes, parentDirectory)) { |
There was a problem hiding this comment.
I feel like there's a risk of getting mystery breakage here if a file happens to begin with the magic number, but it's probably fine for now.
There was a problem hiding this comment.
I agree in principle and and I'm fine with adding a "behavior" but I think if should be a content-type instead of of a behavior and the loading function should be extensible off the type with the pre defined types having default handlers. I think this is a good step towards that goal.
There was a problem hiding this comment.
To add more than sufficient uniqueness we could verify that the manifest parses as json and that
the length of the manifest is less that then length of the data*
- the ability to add another archive at the excess of the previous archive has proven valuable in the past
kg
approved these changes
Jul 18, 2020
|
Looks like this is breaking some empty zip file tests. |
tqiu8
approved these changes
Jul 18, 2020
lewing
added a commit
to lewing/runtime
that referenced
this pull request
Jul 21, 2020
* Add data archive loading to the generic loading logic
lewing
added a commit
that referenced
this pull request
Jul 22, 2020
* ICU integration and asset loading overhaul (#37971) This PR overhauls runtime startup/asset loading and adds support for ICU integration. The mono-config.js format is reworked and simplified, with new functionality added: Individual assets can be loaded from one or more remote sources with configurable fallback behavior In addition to the existing support for loading assemblies, you can now pre-load arbitrary files into the native heap or into emscripten's virtual file system. VFS support previously only existed in runtime-test.js but now is available to any consumer of dotnet.js. Assets can have a virtual path set so that their application-facing path does not necessarily have to match their path on the server. One or more ICU data archives can be added to the assets list and will be automatically loaded and used to enable ICU-based globalization support. Many configuration knobs that previously required API calls can now be set declaratively in the configuration file (environment variables, etc.) WasmAppBuilder is updated to add ICUDataFiles and RemoteSources parameters that can be used to add the associated information to the config file declaratively from a msbuild project. Various adjustments are made to existing tests and test cases so that they will pass with the addition of ICU integration. Co-authored-by: EgorBo <egorbo@gmail.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> * [wasm] Include data archives and timezone data by default (#39586) * Add data archive loading to the generic loading logic * [mono] Update ICU version, disable some tests for Browser (#39596) Co-authored-by: Katelyn Gadd <kg@luminance.org> Co-authored-by: EgorBo <egorbo@gmail.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Add data archive loading to the generic loading logic
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.