Remove unused locals and methods in System.Private.Xml #39592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge this PR until we're done with nullable annotations for XML. Merging may cause unnecessary conflicts with work in progress which we're currently targeting for 5.0, you can track the effort here: #2339 |
krwq
added
the
NO-MERGE
|
@MattKotsenas, can you rebase this on master, now that the PRs @krwq described have been merged? Thanks. |
MattKotsenas
force-pushed
the
refactor/30457-System.Private.Xml
branch
from
5b9548b
to
c6aea7a
Compare
|
@stephentoub, rebased. @krwq, can you take another look when you have a moment? Thanks! |
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/CompilerScopeManager.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/XsltLoader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/XsltLoader.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/tests/XmlDocument/XmlDocumentTests/CreateCDataSectionTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
...ate.Xml/tests/XmlNodeReader/System.Xml.XmlNodeReader.Tests/XmlNodeReaderConstructionTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 15, 2020
src/libraries/System.Private.Xml/tests/XmlDocument/XmlDocumentTests/NameTableTests.cs
Outdated
Show resolved
Hide resolved
MattKotsenas
force-pushed
the
refactor/30457-System.Private.Xml
branch
from
2232f8a
to
1bb3184
Compare
krwq
removed
the
NO-MERGE
krwq
reviewed
Sep 16, 2020
src/libraries/System.Private.Xml/src/System/Xml/Schema/ContentValidator.cs
Outdated
Show resolved
Hide resolved
krwq
reviewed
Sep 16, 2020
src/libraries/System.Private.Xml/src/System/Xml/Schema/SchemaCollectionCompiler.cs
Outdated
Show resolved
Hide resolved
|
I don't have merge permissions, so if everything looks good, please merge on my behalf. If there are any issues or questions, please let me know. Thanks! |
krwq
approved these changes
Sep 17, 2020
|
Thanks @MattKotsenas, looks good to me, let's see if we can get clean CI run first |
|
@krwq you can set auto-merge label in such a case of course |
|
Thanks @MattKotsenas! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused locals and private methods in System.Private.Xml.
This fixes part of #30457