Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup schannel pal #39755

Merged
merged 2 commits into from
Aug 4, 2020
Merged

cleanup schannel pal #39755

merged 2 commits into from
Aug 4, 2020

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 22, 2020

This is followup on #38364 and #37888.

This change unifies SCHANNEL_CRED & SCH_CREDENTIALS handling:

  • We pass it as unmanaged pointer to avoid copy when passed as value.
  • paCred is real type instead of opaque IntPtr
  • caller is responsible to providing correct pointer to avoid double replace in SecuritySafeHandles.AcquireCredentialsHandle

This also removes duplicate Crytypt32.CERT_CONTEXT from certificates_types.cs and uses one from Interop.CERT_CONTEXT.cs. With that, there is more visibility when stepping through in debugger.

@wfurt wfurt requested a review from a team July 22, 2020 04:30
@wfurt wfurt self-assigned this Jul 22, 2020
@ghost
Copy link

ghost commented Jul 22, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

geoffkizer
geoffkizer approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@geoffkizer geoffkizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit 664d9f8 into dotnet:master Aug 4, 2020
@wfurt wfurt deleted the winCrypto branch August 4, 2020 17:28
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@wfurt @Jacksondr5
cleanup schannel pal (dotnet#39755)
43b1509 
* cleanup schannel pal

* fix netfx
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@geoffkizer geoffkizer geoffkizer approved these changes

Assignees

@wfurt wfurt

Labels
area-System.Net.Security os-windows
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wfurt @geoffkizer @karelz