[runtime] Fix GC problems in create_cattr_named()/typed() #39894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… invoke in create_cattr_typed/named_arg (). (dotnet#39774) Hopefully helps with dotnet#39473.
vargaz
requested review from
alexischr,
CoffeeFlux,
lambdageek and
thaystg
as code owners
|
Tagging subscribers to this area: @dotnet/gc |
akoeplinger
approved these changes
Jul 24, 2020
|
Tagging subscribers to this area: @BrzVlad |
|
This was approved by .NET Core Tactics, merging. |
|
@Anipik will this automatically cause a new build to flow? |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39774 and #39856 to the
release/5.0-preview8branch.Fixes #39473 (Tests failed on WASM with NRE in CustomAttributeTypedArgument.CanonicalizeValue)
Description
Fixes an issue where the Mono runtime/GC wasn't correctly tracking newly created objects when creating a custom attribute type. This resulted in rare and random
NullReferenceException's during the dotnet/runtime libraries tests. We also got one report from Blazor that looks like the same thing.Customer Impact
Random
NullReferenceExceptionwhen creating custom attribute instances.Risk
Low, we ran several libraries tests in a loop for multiple hours to confirm the issue was fixed.