Fix zero connection timeout issue #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
approved these changes
Nov 30, 2019
stephentoub
requested changes
Nov 30, 2019
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNITcpHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Dec 3, 2019
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNITcpHandle.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Dec 3, 2019
|
Any reasons why the token registration is not disposed? |
|
The CTS it's registered with is thrown away. |
ghost
locked as resolved and limited conversation to collaborators
radical
pushed a commit
to radical/runtime
that referenced
this pull request
Jul 7, 2022
Resolves dotnet#400 The ios command will keep working with a warning displayed that it is obsolete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue is from dotnet/SqlCLient #58 .
Backport the PR#332 from Microsoft.Data.SqlClient to System.Data.SqlClient.