Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Pass delegate target when using CreateDelegate #40321

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Aug 4, 2020

Fixes #40037

@vargaz
Copy link
Contributor

vargaz commented Aug 4, 2020

Looks ok, but why didn't this cause any test failures etc. ?

@BrzVlad
Copy link
Member Author

BrzVlad commented Aug 4, 2020

@vargaz I guess there was a lack of testing of this. Added testcase. Note that this bug was introduced when creating the System.Private.Corlib files, it was not present on net4x.

@BrzVlad BrzVlad force-pushed the fix-create-delegate branch from bf3954e to 05c3b9f Compare August 5, 2020 09:14
@BrzVlad BrzVlad merged commit fe41d3c into dotnet:master Aug 5, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
* Pass delegate target when using CreateDelegate

* [tests] Add test that checks `this` with CreateDelegate API
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor WebAssembly preview 7 failing with 'Why are we accessing an entry that is not allocated'
4 participants