Add support for reporting byrefs to RVA static fields of collectible assemblies #40346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assemblies - Keep track of all RVA static field locations - For assemblies loaded from PE files, use a range that is the entire PE range - For assemblies dynamically created, use piecemeal ranges for each individual RVA static field - Report byref references via the GcReportLoaderAllocator mechanism in PromoteCarefully - Add a test to cover this scenario
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
davidwrighton
added
area-VM-coreclr
and removed
area-CodeGen-coreclr
|
Do we have a similar problem when the RVA static is in the TLS range? I assume this is the sort of stuff C++/CLI would produce (...or IL with |
|
C++/CLI is incompatible with collectible assemblies in many ways, so we can't support it properly in any case. For regular thread static fields, you are right, that is worth a test, and I've tweaked the test to include that scenario. However, the way it works in CoreCLR today is ThreadStatic fields use heap objects in any case, so the test passes just fine. |
jkotas
approved these changes
Aug 5, 2020
|
:mips-interest |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…assemblies (dotnet#40346) - Keep track of all RVA static field locations - For assemblies loaded from PE files, use a range that is the entire PE range - For assemblies dynamically created, use piecemeal ranges for each individual RVA static field - Report byref references via the GcReportLoaderAllocator mechanism in PromoteCarefully - Add a test to cover this scenario, and thread statics - disable test on Mono, as it doesn't pass there yet
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for reporting byrefs to RVA static fields of collectible assemblies
Keep track of all RVA static field locations
Report byref references via the GcReportLoaderAllocator mechanism in PromoteCarefully
Add a test to cover this scenario
fixes #13348