Make UseEnvironment/ContentRoot override config #41003
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/aspnetcore#18499
UseEnvironment and UseContentRoot have a composition problem. Because they were implemented using config they're order sensitive and can be overridden by config. That has caused confusion especially for UseEnvironment.
Proposal: Have UseEnvironment and UseContentRoot store their data in IHostBuilder.Properties rather than config and treat this as higher priority than config. This works well for UseEnvironment, but there are a few places where UseContentRoot is used to provide a default value that is intended to compose with config. Those can be easily expressed using ConfigureHostConfig like UseContentRoot used to.
There's at least one more UseContentRoot call in UseWindowsServices we might want to update.
https://github.com/dotnet/extensions/blob/f4066026ca06984b07e90e61a6390ac38152ba93/src/Hosting/WindowsServices/src/WindowsServiceLifetimeHostBuilderExtensions.cs#L50