Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default non-portable build for armel #41031

Merged

Conversation

gbalykov
Copy link
Member

This is required for build of native part of tests as non-portable and managed part of tests as portable. Also, this makes armel tizen build consistent with arm64 tizen build scheme, which requires --portable false option. Example of tizen build:

ROOTFS_DIR=`pwd`/.tools/rootfs/armel ./build.sh --portablebuild false --cross --clang9 --arch armel --configuration Release --subset clr+libs.native
ROOTFS_DIR=`pwd`/.tools/rootfs/armel ./build.sh --cross --clang9 --arch armel --configuration Release --subset libs.ref+libs.src+libs.pretest+libs.packages+libs.tests

Build of tests can be performed similar to #40979 (comment):

cd src/coreclr
ROOTFS_DIR=`pwd`/../../.tools/rootfs/armel ./build-test.sh -release portablebuild=false -cross -armel -clang9 -priority1 skipgenerateversion skipstressdependencies skipmanaged skipgeneratelayout skiprestorepackages /p:__SkipPackageRestore=true
ROOTFS_DIR=`pwd`/../../.tools/rootfs/armel ./build-test.sh -release -cross -armel -clang9 -priority1 skipgenerateversion skipstressdependencies skipnative skipgeneratelayout skiptestwrappers
ROOTFS_DIR=`pwd`/../../.tools/rootfs/armel ./build-test.sh -release -cross -armel -clang9 -priority1 skipgenerateversion skipstressdependencies copynativeonly
ROOTFS_DIR=`pwd`/../../.tools/rootfs/armel ./build-test.sh -release -cross -armel -clang9 -priority1 skipgenerateversion skipstressdependencies generatelayoutonly

cc @alpencolt @jkotas

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas
Copy link
Member

jkotas commented Aug 19, 2020

CI failures are #41006

@jkotas jkotas merged commit b9d26c8 into dotnet:master Aug 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants