Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability on System.Xml.XPath #41060

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Enable nullability on System.Xml.XPath #41060

merged 2 commits into from
Aug 20, 2020

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 19, 2020 •
edited
Loading

Contributes to #2339
No annotations are needed for the APIs exposed in this assembly.
Add missing annotations to XPathException.

@jozkee jozkee added this to the 5.0.0 milestone Aug 19, 2020
@jozkee jozkee requested review from krwq and buyaa-n August 19, 2020 21:50
@jozkee jozkee self-assigned this Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

stephentoub commented Aug 19, 2020 •
edited
Loading

No annotations are needed for the APIs exposed in this assembly.

That doesn't sound right. For example, I see there's an XpathException type, and its message and innerException ctor arguments should be nullable.

@buyaa-n
Copy link
Contributor

buyaa-n commented Aug 19, 2020

Constructor overloads accept nullable
https://source.dot.net/#System.Private.CoreLib/Exception.cs,32

@jozkee
Copy link
Member Author

jozkee commented Aug 19, 2020

@stephentoub @buyaa-n you are right, I missed the message parameter in the src annotations as well. Will add them here.

jeffhandley
jeffhandley approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@jeffhandley jeffhandley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @buyaa-n can you take a look too?

Never mind -- I see you already did; I needed to refresh.

buyaa-n
buyaa-n approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeffhandley
Copy link
Member

@jozkee Is there anything left on this one, or is it ready for merge? Did you want a review from @krwq first?

@jozkee
Copy link
Member Author

jozkee commented Aug 20, 2020

@jeffhandley I think is fine, will merge now...

@jozkee jozkee merged commit 6891633 into dotnet:master Aug 20, 2020
@jozkee jozkee deleted the nullability_5 branch August 20, 2020 05:41
@krwq
Copy link
Member

krwq commented Aug 20, 2020

LGTM thanks!

@carlossanlop carlossanlop mentioned this pull request Aug 25, 2020
Merged
14 tasks
carlossanlop pushed a commit to carlossanlop/runtime that referenced this pull request Aug 28, 2020
@jozkee @carlossanlop
Enable nullability on System.Xml.XPath (dotnet#41060)
44390bc 
* Enable nullability on System.Xml.XPath

* Switch XPathException ctor's message parameter to string?
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

@buyaa-n buyaa-n buyaa-n approved these changes

@krwq krwq Awaiting requested review from krwq

Assignees

@jozkee jozkee

Labels
area-System.Xml
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jozkee @stephentoub @buyaa-n @jeffhandley @krwq