Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change nullability of public IXmlNamespaceResolver parameters where appropriate #41079

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Change nullability of public IXmlNamespaceResolver parameters where appropriate #41079

merged 1 commit into from
Aug 20, 2020

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 20, 2020 •
edited
Loading

As per #40744 (comment):
Changes parameter to IXmlNamespaceResolver? in the following methods:

XmlReader.ReadContentAs(Type, IXmlNamespaceResolver?)
XmlReader.ReadContentAsAsync(Type, IXmlNamespaceResolver?)
XPathExpression.SetContext(IXmlNamespaceResolver?)
XPathNavigator.Select(string, IXmlNamespaceResolver?)
XPathNavigator.Evaluate(string, IXmlNamespaceResolver?)

@jozkee jozkee added this to the 5.0.0 milestone Aug 20, 2020
@jozkee jozkee requested review from krwq and a team August 20, 2020 07:35
@jozkee jozkee self-assigned this Aug 20, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

@jozkee jozkee mentioned this pull request Aug 20, 2020
Merged
@jozkee jozkee merged commit 0a0eeae into dotnet:master Aug 20, 2020
@carlossanlop carlossanlop mentioned this pull request Aug 25, 2020
Merged
14 tasks
@jozkee jozkee mentioned this pull request Aug 27, 2020
Merged
carlossanlop pushed a commit to carlossanlop/runtime that referenced this pull request Aug 28, 2020
@jozkee @carlossanlop
Change nullability of public IXmlNamespaceResolver parameters where a…
1e723ce 
…ppropriate (dotnet#41079)
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@jozkee jozkee deleted the nullability_ixmlnamespaceresolver branch March 24, 2021 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq approved these changes

Assignees

@jozkee jozkee

Labels
area-System.Xml
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jozkee @krwq