Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port EventPipe CoreCLR changes to Mono. #41152

Conversation

lateralusX
Copy link
Member

Port changes done in the following CoreCLR PR's affecting corresponding Mono runtime EventPipe library sources:

#36720
#37002
#38967
#40191
#40332
#40499

EventPipe native code changes track by #36820.

Mono port of CoreCLR PR: dotnet#40332.

NOTE, the ability to pause a session was not ported since it
currently have no use in Mono and looks like a temporary
solution in CoreCLR.
@lateralusX
Copy link
Member Author

@josalem Port of changes done to EventPipe source in CoreCLR over to corresponding Mono C port of EventPipe library.

Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@lateralusX lateralusX merged commit 858ec52 into dotnet:master Aug 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants