-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Mark System.Diagnostics.Process APIs as unsupported on Browser #41694
Merged
mdh1418
merged 1 commit into
dotnet:master
from
mdh1418:mdhwang/system_diagnostics_process_unsupported
Sep 4, 2020
Merged
[wasm] Mark System.Diagnostics.Process APIs as unsupported on Browser #41694
mdh1418
merged 1 commit into
dotnet:master
from
mdh1418:mdhwang/system_diagnostics_process_unsupported
Sep 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
requested review from
lewing,
steveisok,
akoeplinger and
MaximLipnin
September 1, 2020 19:38
Tagging subscribers to this area: @safern, @ViktorHofer |
mdh1418
force-pushed
the
mdhwang/system_diagnostics_process_unsupported
branch
from
September 1, 2020 19:38
9c1c5d3
to
afdb8b1
Compare
71 tasks
mdh1418
force-pushed
the
mdhwang/system_diagnostics_process_unsupported
branch
6 times, most recently
from
September 3, 2020 03:32
c59bd34
to
2f63b76
Compare
It seems like you're missing some attributes
|
mdh1418
force-pushed
the
mdhwang/system_diagnostics_process_unsupported
branch
2 times, most recently
from
September 3, 2020 21:24
827b0bb
to
d1fe334
Compare
akoeplinger
approved these changes
Sep 4, 2020
danmoseley
added
area-System.Diagnostics.Process
and removed
area-Infrastructure-libraries
labels
Sep 5, 2020
mdh1418
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 8, 2020
…#41694) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
mdh1418
added a commit
that referenced
this pull request
Sep 9, 2020
* [wasm] Mark System.ComponentModel APIs as unsupported on Browser (#41094) * [wasm] System.ComponentModel enable platform attributes * [wasm] Mark ExtendedProtectionPolicyTypeConverter.ConvertTo as unsupported * [wasm] Mark System.ComponentModel.TypeDescriptor.CreateInstance as unsupported * [wasm] Mark System.ComponentModel.TypeDescriptionProvider.CreateInstance as unsupported * [wasm] Mark System.ComponentModel.LicenseManager.CreateWithContext as unsupported * [wasm] Mark System.ComponentModel.MaskedTextProvider.Clone as unsupported Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.Console APIs as unsupported on Browser (#41184) * [wasm] Mark System.Console APIs as unsupported on Browser * System.Console remove unsupported attribute from Console.Clear() * System.Console mark SetIn as unsupported on Browser * System.Console move UnsupportedOSPlatform attributes down to the accessor Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark System.Diagnostics.FileVersionInfo as unsupported on Browser (#41271) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark System.Diagnostics.Process unsupported at assembly level (#41694) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.IO.Compression APIs as unsupported on Browser (#41683) * [wasm] System.IO.Compression.Brotli enable platform attributes * Mark System.IO.Compression.Brotli unsupported at assembly level Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.IO.FileSystem.Watcher APIs as unsupported on Browser (#41682) * [wasm] System.IO.FileSystem.Watcher enable platform attributes * Mark System.IO.FileSystem.Watcher unsupported at assembly level Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * [wasm] Mark System.IO.IsolatedStorage APIs as unsupported on Browser (#41700) * [wasm] System.IO.IsolatedStorage enable platform attributes * Mark System.IO.IsolatedStorage Unsupported at assembly level Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark some System.Net.* APIs as unsupported on Browser WASM (#40924) * [wasm] Mark System.Threading.ThreadPool unsupported on Browser (#41891) * System.Threading.ThreadPool enable platform attributes * Mark System.Threading.ThreadPool APIs unsupported on browser * System.Threading.ThreadPool Add Unsupported attribute to other ThreadPool files * Remove Unsupported attributes from BindHandle * Add windows Supported Attribute to BindHandle Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> * Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser (#41963) * Mark System.Net.WebSockets.ClientWebSocketOptions APIs as unsupported on Browser * Add the attributes to non-browser version of ClientWebSocketOptions class to avoid build error * Add using * Include platform attributes * [wasm] Mark System.Net.NameResolution Unsupported at assembly level (#41985) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com> Co-authored-by: Maxim Lipnin <v-maxlip@microsoft.com>
mdh1418
added a commit
to mdh1418/runtime
that referenced
this pull request
Sep 11, 2020
…#41694) Co-authored-by: Mitchell Hwang <mitchell.hwang@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #41087
Deprecated
NonpagedSystemMemorySize
PagedMemorySize
PagedSystemMemorySize
PeakPagedMemorySize
PeakVirtualMemorySize
PeakWorkingSet
PrivateMemorySize
VirtualMemorySize
WorkingSet
Windows-only
Start(string fileName, string userName, /System/./Security/./SecureString/ password, string domain)
Start(string fileName, string arguments, string userName, /System/./Security/./SecureString/ password, string domain)
Domain
LoadUserProfile
Password
PasswordInClearText