Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unix build issues #42104

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Fix Unix build issues #42104

merged 2 commits into from
Sep 11, 2020

Conversation

davidwrighton
Copy link
Member

  • Fix Unix clr.jit and clr.alljits subsets build
    • Currently it won't work on Unix due to issues building createdump and missing mscorrc
  • When native build fails, handle exit code properly by checking it immediately after cmake is called

@davidwrighton
Fix Unix clr.jit and clr.alljits subsets build
3873732 
When native build fails, handle exit code properly by checking it immediately after cmake is called
@am11
Copy link
Member

am11 commented Sep 11, 2020

I think this will close #34496.

@janvorli
Copy link
Member

I can confirm that it fixes #34496, that's great!

janvorli
janvorli approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@davidwrighton davidwrighton merged commit cd7d23f into dotnet:master Sep 11, 2020
@davidwrighton davidwrighton mentioned this pull request Sep 11, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@davidwrighton davidwrighton deleted the fix_linux_build_issues branch April 20, 2021 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli approved these changes

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky

Assignees
No one assigned
Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwrighton @am11 @janvorli @Dotnet-GitSync-Bot