Fix default handling for value types when converter based on interface #42319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
commented
Sep 16, 2020
| } | ||
|
|
||
| [Fact] | ||
| public static void JsonIgnoreCondition_WhenWritingDefault_OnBoxedPrimitive() |
There was a problem hiding this comment.
This was passing before, just added the test.
steveharter
commented
Sep 16, 2020
| } | ||
|
|
||
| [Fact] | ||
| public static void JsonIgnoreCondition_WhenWritingDefault_OnRootTypes() |
There was a problem hiding this comment.
This was passing before, just added the test.
layomia
reviewed
Sep 16, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/GenericMethodHolder.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoOfT.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoOfT.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoOfT.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Serialization/PropertyVisibilityTests.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Serialization/PropertyVisibilityTests.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Serialization/PropertyVisibilityTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Serialization/PropertyVisibilityTests.cs
Outdated
Show resolved
Hide resolved
layomia
approved these changes
Sep 17, 2020
|
Runtime failure in mono unrelated:
|
layomia
pushed a commit
to layomia/dotnet_runtime
that referenced
this pull request
Sep 17, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42237
When a custom converter is based on an interface and a corresponding property is based on a value type that implements the interface, default handling was not working. This PR fixes that.
Some local benchmarks showed no regression for the happy path that doesn't hit this edge case.