-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code for GC Poll marking and insertion. #42664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Sep 24, 2020
x64 pmi framework diffs:
|
@dotnet/jit-contrib @jkotas PTAL |
jkotas
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
sandreenko
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jit changes look good, thank you.
erozenfeld
force-pushed
the
RemoveGCPolls
branch
from
September 24, 2020 19:23
5dcd6d5
to
ba2121d
Compare
This is a follow-up to dotnet#13582 (comment) and dotnet#13582 (comment) The code to insert gc polls was added in desktop for gc suspension not based on hijaking. All platforms we target support hijaking so this code is not exercised or tested. It also clutters other code and adds a bit of runtime overhead. This change removes all that code. There are minimal asm diffs because of a removed call to `fgRenumberBlocks`.
erozenfeld
force-pushed
the
RemoveGCPolls
branch
from
September 24, 2020 20:31
ba2121d
to
d90e704
Compare
ghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to
#13582 (comment)
and
#13582 (comment)
The code to insert gc polls was added in desktop for gc suspension not based
on hijaking. All platforms we target support hijaking so this code is not exercised
or tested. It also clutters other code and adds a bit of runtime overhead.
This change removes all that code.
There are minimal asm diffs because of a removed call to
fgRenumberBlocks
.pin-icount reports a small but measurable throughput improvement when crossgen-ing SPC on x64: 0.07% (noise level is less than 0.01%).