Fix test framework crossgening #42874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change that replaced direct invocation of crossgen and crossgen2 for crossgening framework assemblies for coreclr tests by r2rtest tool usage has ommited the --release and --large-bubble arguments. These correspond to the former -O and --inputbubble crossgen2 commands and should be present. This also fixes failures in running tests with the crossgened runtime. Many tests were failing with the error `Could not execute the method because either the method itself or the containing type is not fully instantiated.` So while there is a problem to investigate related to debug flavor of crossgening, this PR fixes the options.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change that replaced direct invocation of crossgen and
crossgen2 for crossgening framework assemblies for coreclr tests by
r2rtest tool usage has ommited the --release and --large-bubble
arguments. These correspond to the former -O and --inputbubble crossgen2
commands and should be present.
This also fixes failures in running tests with the crossgened runtime.
Many tests were failing with the error
Could not execute the method because either the method itself or the containing type is not fully instantiated.So while there is a problem to investigate related to debug flavor of
crossgening, this PR fixes the options.