Verify that OCSP and CRL checks fall back. #43586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that a CRL timeout chain build will use OCSP. Test that a OCSP timeout chain build will use CRL.
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley |
vcsjones
commented
Oct 19, 2020
| Aia = 0b100, | ||
| All = 0b11111111 | ||
| } | ||
| public enum DelayedActionsFlag : byte |
There was a problem hiding this comment.
This needed to be changed to public for test method parameters; enclosing type is internal so move it out.
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like all the failing outerloop tests are unrelated. None of the S.S.Cryptography tests failed. |
bartonjs
approved these changes
Nov 19, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that a CRL timeout chain build will use OCSP.
Test that a OCSP timeout chain build will use CRL.
This also changes the
RevocationResponderto dispatch each request on the thread pool. Since we are simulating delays with sleeps, previously the sleep would span all requests for the responder.Closes #38875