Fill out hardware intrinsics linker substitutions for unsupported platforms #44156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
approved these changes
Nov 2, 2020
|
Tagging subscribers to this area: @tannergooding, @jeffhandley |
jkotas
approved these changes
Nov 2, 2020
jkotas
added
the
linkable-framework
marek-safar
reviewed
Nov 2, 2020
| @@ -9,6 +9,9 @@ | |||
| <type fullname="System.Runtime.Intrinsics.Arm.Aes"> | |||
There was a problem hiding this comment.
I think it's worth splitting this up to to arm and arm64 files so we can disable arm64 intrinsics on arm builds.
There was a problem hiding this comment.
We don't support intrinsics on arm32 at all at this point. Check out the project file, we only support arm intrinsics on arm64:
We can split the file in the future when arm32 support is understood.
There was a problem hiding this comment.
ok, will split that once we support them
This was referenced Nov 2, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the recently added arm intrinsics classes:
DpandRdmto the linker subsitutions.I also ensured all the 64-bit nested classes are substituted as well, even if they don't have any methods.
Fix #44146