Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illumos native build #44251

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix illumos native build #44251

merged 2 commits into from
Nov 5, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented Nov 4, 2020

Three errors were reported by illumos crossbuild (gcc8 on linux targetting illumos); one each in coreclr, installer and libraries.

  1. Missing header guard for PCH (not sure why it does not happen in CI running gcc7 for native linux compile?):
  [ 56%] Building CXX object src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/commandline.cpp.o
  In file included from /runtime/src/coreclr/src/ToolBox/superpmi/superpmi/commandline.cpp:10:
  /runtime/src/coreclr/src/ToolBox/superpmi/superpmi/../superpmi-shared/standardpch.h:114:20: error: redefinition of 'void __debugbreak()'
   static inline void __debugbreak()
                      ^~~~~~~~~~~~
  In file included from /runtime/artifacts/obj/coreclr/illumos.x64.Release/src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/cmake_pch.hxx:5,
                   from <command-line>:
  /runtime/src/coreclr/src/ToolBox/superpmi/superpmi/../superpmi-shared/standardpch.h:114:20: note: 'void __debugbreak()' previously defined here
   static inline void __debugbreak()
                      ^~~~~~~~~~~~
  src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/build.make:97: recipe for target 'src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/commandline.cpp.o' failed
  CMakeFiles/Makefile2:4320: recipe for target 'src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/all' failed
  make[2]: *** [src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/commandline.cpp.o] Error 1
  make[1]: *** [src/ToolBox/superpmi/superpmi/CMakeFiles/superpmi.dir/all] Error 2
  make[1]: *** Waiting for unfinished jobs....
  1. System.Globalization with ICU is now building as part of libraries (previously it was in coreclr), so it needed HAVE_SET_MAX_VARIABLE from coreclr's tryrun.cmake to the one under libraries.

  2. Corehost's static plan requires -lsocket when linking libcoreclr.

cc @janvorli

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
Copy link
Member

janvorli commented Nov 5, 2020

The crash in System.Runtime.Serialization.Formatters.Tests is #44250

@janvorli janvorli merged commit 80c16e3 into dotnet:master Nov 5, 2020
@am11 am11 deleted the feature/sunos/native-build branch November 5, 2020 21:48
@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants