Remove LazyInitializer usage from corelib #44409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
stephentoub
force-pushed
the
lazyinit
branch
2 times, most recently
from
a98ef10
to
f51f5aa
Compare
marek-safar
reviewed
Nov 9, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.GetFolderPathCore.Unix.cs
Outdated
Show resolved
Hide resolved
jkotas
added
the
linkable-framework
stephentoub
force-pushed
the
lazyinit
branch
2 times, most recently
from
fe54006
to
5d706e5
Compare
jkotas
reviewed
Nov 11, 2020
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.Core.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 11, 2020
src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.Core.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
lazyinit
branch
from
5d706e5
to
1c1066e
Compare
It's fine for higher layers, but in corelib we don't want to forcibly prevent LazyInitializer from being trimmed nor pay the overheads of additional cached delegates.
stephentoub
force-pushed
the
lazyinit
branch
from
1c1066e
to
7eb1835
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fine for higher layers, but in corelib we don't want to forcibly prevent LazyInitializer from being trimmed nor pay the overheads of additional cached delegates.
cc: @jkotas