Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in Hosting test #44548

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

eerhardt
Copy link
Member

Change Task.Delay(1) to Task.Yield() to avoid a super race condition.

Fix #43389

Change Task.Delay(1) to Task.Yield() to avoid a super race condition.

Fix dotnet#43389
@ghost
Copy link

ghost commented Nov 11, 2020

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.


Issue meta data

Issue content: Change Task.Delay(1) to Task.Yield() to avoid a super race condition.

Fix #43389

Issue author: eerhardt
Assignees: -
Milestone: -

@eerhardt
Copy link
Member Author

Failures are:

OSX: #30056
Linux: https://github.com/dotnet/core-eng/issues/11391

@stephentoub stephentoub merged commit 26dba43 into dotnet:master Nov 12, 2020
@eerhardt eerhardt deleted the Fix43389 branch November 12, 2020 13:06
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Microsoft.Extensions.Hosting.Internal.HostTests.BackgroundServiceAsyncExceptionGetsLogged
3 participants