Fix add user secrets #44838
Merged
Fix add user secrets #44838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @maryamariyan Issue Details
|
|
@maryamariyan @safern ping |
|
@galakt thanks for the PR. will take a look |
| File.Delete(secretPath); | ||
| } | ||
|
|
||
| Assert.Throws<FileNotFoundException>(() => new ConfigurationBuilder().AddUserSecrets(Assembly.GetExecutingAssembly(), false).Build()); |
There was a problem hiding this comment.
nit: ideally you'd only want to keep the method that you're asserting behavior within the Assert.Throws block.
safern
reviewed
Nov 20, 2020
| @@ -169,6 +169,9 @@ public static IConfigurationBuilder AddUserSecrets(this IConfigurationBuilder co | |||
| /// <param name="reloadOnChange">Whether the configuration should be reloaded if the file changes.</param> | |||
| /// <returns>The configuration builder.</returns> | |||
| public static IConfigurationBuilder AddUserSecrets(this IConfigurationBuilder configuration, string userSecretsId, bool reloadOnChange) | |||
| => AddUserSecretsInternal(configuration, userSecretsId, true, reloadOnChange); | |||
There was a problem hiding this comment.
nit, usually we name bool parameters. It is not a big deal, but for next time. It helps understand what the true is for when reading the call site.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44150