Fix issue 44646 - ILAsm incorrectly handles method .custom attribute when we have generic type constraint #44850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when we have generic type constraint The IL Assembler incorrectly dropped a .custom attribute for the method This only occurred when the inline syntax for generic type parameters was used in the method definition. This behavior can also occur for a generic class definition.
|
@dotnet/jit-contrib @BruceForstall PTAL |
|
This also fixes #32400 |
This was
linked to
issues
Nov 18, 2020
dseefeld
added a commit
to dseefeld/source-build
that referenced
this pull request
Nov 18, 2020
Patch is from dotnet/runtime#44850 Fixes issue dotnet/runtime#44646
BruceForstall
approved these changes
Nov 18, 2020
src/coreclr/src/ilasm/assembler.cpp
Outdated
| } | ||
|
|
||
| // returns true if we create a new GenericParamConstraintDescriptor | ||
| // reurns false if we return an already existing GenericParamConstraintDescriptor | ||
| // CheckAddGenericParamConstraint is called when we have to handle a generic parameter constariant |
dseefeld
added a commit
to dotnet/source-build
that referenced
this pull request
Nov 19, 2020
Patch is from dotnet/runtime#44850 Fixes issue dotnet/runtime#44646
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IL Assembler incorrectly dropped a .custom attribute for a method
This only occurs when the inline syntax for generic type parameters is used in the method definition.
This behavior can also occur for a generic class definition.
This changes fixes this issue for both generic classes and generic methods
#44646