Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete now unused target in crossgen2.csproj. #44888

Merged
1 commit merged into from
Nov 18, 2020

Conversation

jkoritzinsky
Copy link
Member

This target was used by the old framework pack tooling to create the crossgen2 pack. The new tooling doesn't use this target.

Signed-off-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for cleaning this up!

@ghost
Copy link

ghost commented Nov 18, 2020

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 42ffc8f into dotnet:master Nov 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
@jkoritzinsky jkoritzinsky deleted the crossgen2-cleanup branch January 21, 2021 19:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants