Move xunit test harness to its own directory under core_root #44921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Addresses #44807 |
trylek
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Looks great, apparently it truly fixes the problem. For the one remaining failure in R2RDumpTests, I'm wondering whether you may have used a slightly stale runtime clone as I fixed this bug last week by moving the test under readytorun/r2rdump/FrameworkTests. Thank you!
Running `xunit.console` from within the CoreRoot directory is problematic. It is executed by the shared runtime but has a full copy of the runtime and framework libraries next to it from which assemblies are getting loaded despite being for a pre-release test runtime. Place the xunit assemblies under `<core_root>/xunit` and update the places that invoke it in local and Helix test runs. The loaded tests do reference the xunit assemblies so they need to also be available in core_root for when the tests run (with the exception of the harness specific assemblies like xunit.console).
nattress
force-pushed
the
movexunitrunner
branch
from
18eef5b
to
11d1aad
Compare
|
Yeah I did use a stale branch. I re-ran and that test passes now. There are a couple regressions on Windows but it's good enough quality to merge and unblock the outerloop runtime legs. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
xunit.consolefrom within the CoreRoot directory is problematic. It is executed by the shared runtime but has a full copy of the runtime and framework libraries next to it from which assemblies are getting loaded despite being for a pre-release test runtime.Place the xunit assemblies under
<core_root>/xunitand update the places that invoke it in local and Helix test runs.The loaded tests do reference the xunit assemblies so they need to also be available in core_root for when the tests run (with the exception of the harness specific assemblies like xunit.console).