Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark stress log critical section as compatible with shutdown #44937

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Mark stress log critical section as compatible with shutdown #44937

merged 1 commit into from
Nov 19, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Nov 19, 2020

Fixes: #43571

/cc @dotnet/dotnet-coreclr

@trylek trylek added this to the 6.0.0 milestone Nov 19, 2020
@trylek trylek requested a review from janvorli November 19, 2020 09:18
VSadov
VSadov approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@trylek trylek merged commit 3f97ea6 into dotnet:master Nov 19, 2020
@trylek trylek deleted the CrstTakenDuringShutdown branch November 19, 2020 20:59
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VSadov VSadov VSadov approved these changes

@janvorli janvorli janvorli approved these changes

@AntonLapounov AntonLapounov AntonLapounov approved these changes

Assignees
No one assigned
Labels
area-VM-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

Attempting to take a lock at shutdown that is not CRST_TAKEN_DURING_SHUTDOWN
4 participants
@trylek @VSadov @janvorli @AntonLapounov