Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register allocation cleanup #44977

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Register allocation cleanup #44977

merged 2 commits into from
Nov 20, 2020

Conversation

kunalspathak
Copy link
Member

While I was walking through the register allocator code, I saw few comments/code that was outdated.

@kunalspathak
Register allocation cleanup
bd5832d 
- Comment updates
- Misc code cleanup
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 20, 2020
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

CarolEidt
CarolEidt approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the cleanup!

@kunalspathak kunalspathak merged commit 07193b8 into dotnet:master Nov 20, 2020
@kunalspathak kunalspathak mentioned this pull request Nov 26, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CarolEidt CarolEidt CarolEidt approved these changes

@sandreenko sandreenko sandreenko left review comments

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kunalspathak @CarolEidt @sandreenko @Dotnet-GitSync-Bot