Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Introduce AndroidApkFileReplacerTask task #44993

Merged
merged 5 commits into from
Nov 23, 2020
Merged

[Android] Introduce AndroidApkFileReplacerTask task #44993

merged 5 commits into from
Nov 23, 2020

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Nov 20, 2020

Allows to quickly replace a specific file in an existing APK = test changes without full APK rebuild.

Usage example:

<AndroidApkFileReplacerTask OutputDir="$(ApkDir)" FilePath="lib/x86_64/libSystem.Native.so" />

mdh1418
mdh1418 approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (after the apkPath change?)

@EgorBo EgorBo merged commit 65d42f0 into dotnet:master Nov 23, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdh1418 mdh1418 mdh1418 approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-Build-mono os-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @mdh1418