Fix parsed RID condition for VS

[am11]

cc @stephentoub, @ViktorHofer

[ghost]

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

cc @stephentoub, @ViktorHofer

Author:	am11
Assignees:	-
Labels:	area-System.Configuration
Milestone:	-

[am11]

@stephentoub, could you please confirm if it has fixed the VS loading problem? I am not in front of Windows machine rn. :)

[stephentoub]

It does. Thanks.

How did this get checked in with the VS experience entirely broken?

[am11]

Thanks for checking. :)
We have consolidated all rid/os/arch/targetplatform property definitions in Configuration.props in #43804. I was using command line to test on different platforms. I think we don't have anything in CI which validates VS experience.

[stephentoub]

We have consolidated all rid/os/arch/targetplatform property definitions in Configuration.props in #43804. I was using command line to test on different platforms. I think we don't have anything in CI which validates VS experience.

@ViktorHofer, in the future, can we make sure that any PRs like that one which impact VS experience are validated manually before merging? Thanks!

[stephentoub]

Merging to unblock folks working in the repo.

[ViktorHofer]

@ViktorHofer, in the future, can we make sure that any PRs like that one which impact VS experience are validated manually before merging? Thanks!

I didn't consider the change to impact VS. Let's come up with a policy and define what kind of changes need additional manual validation.

[ViktorHofer]

LGTM. Thanks

[am11]

Thanks. @ViktorHofer, would it make sense that one of the windows leg with VS installed, exercise an additional quick step after the build, to validate the VS well being. Something like:

:: build just one SLN with devenv.exe at the end of a CI job

devenv.exe /Build "Release|x64" ^
  src\libraries\Microsoft.Extensions.DependencyModel\Microsoft.Extensions.DependencyModel.sln