Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Throw when resolving on a disposed service provider #45116

Merged
merged 18 commits into from
Dec 4, 2020
Merged

Breaking change: Throw when resolving on a disposed service provider #45116

merged 18 commits into from
Dec 4, 2020
+164 −4

Commits on Nov 23, 2020

  1. Breaking change: Throw when resolving on a disposed service provider 

    - Resolving Services after ServiceProvider is Disposed should throw with ObjectDisposedException
    @maryamariyan
    maryamariyan committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    ba6cc3b View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/Microsoft.Extensions.DependencyInjection/tests/D… 

    …I.Tests/ServiceProviderContainerTests.cs
    @maryamariyan
    maryamariyan authored Nov 23, 2020
    Configuration menu
    Copy the full SHA
    f5fae4c View commit details
    Browse the repository at this point in the history

  3. PR feedback + Add simpler test

    @maryamariyan
    maryamariyan committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    91d6053 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Dispose missed disposables before throwing + Cleanup

    @maryamariyan
    maryamariyan committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    6d3f4fa View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary line

    @maryamariyan
    maryamariyan committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    9d9c9ae View commit details
    Browse the repository at this point in the history

  3. dispose service before throw

    @maryamariyan
    maryamariyan committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    3931f61 View commit details
    Browse the repository at this point in the history

  4. Add test code coverage for IAsyncDispoable service

    @maryamariyan
    maryamariyan committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    5a12704 View commit details
    Browse the repository at this point in the history

  5. correction

    @maryamariyan
    maryamariyan committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    eddbd6f View commit details
    Browse the repository at this point in the history

  6. cleanup

    @maryamariyan
    maryamariyan committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    4f3690e View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Add code coverage for DisposeAsync

    @maryamariyan
    maryamariyan committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    fa01467 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. include SingleThreadSynchronizationContext for DI.Tests"

    @maryamariyan
    maryamariyan committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    bf3435e View commit details
    Browse the repository at this point in the history

  2. Corrections - fire-and-forget and add test

    @maryamariyan
    maryamariyan committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    e3317ff View commit details
    Browse the repository at this point in the history

  3. PR feedback

    @maryamariyan
    maryamariyan committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    5fd7abd View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Add comment

    @maryamariyan
    maryamariyan committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    074800a View commit details
    Browse the repository at this point in the history

  2. use sync over async and update comment

    @maryamariyan
    maryamariyan committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    c9e1c54 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Test improvements + nit feedback

    @maryamariyan
    maryamariyan committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    90a2a98 View commit details
    Browse the repository at this point in the history

  2. Remove useless test

    @maryamariyan
    maryamariyan committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    5327789 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. - Assert in test that service gets disposed

    @maryamariyan
    maryamariyan committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    7864401 View commit details
    Browse the repository at this point in the history