Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Http2_PingKeepAlive #45214

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Nov 25, 2020

The high numbers of failures seem to be temporary in the end. My assumption about product code change was probably false.
We might hold this PR back for a few more days to confirm this.

Numbers per day (kusto):

Disabled test tracked in #41929

Queued Count
2020-09-26 1
2020-09-27 2
2020-09-28 2
2020-09-29 7
2020-09-30 2
2020-10-01 1
2020-10-02 4
2020-10-03 4
2020-10-04 3
2020-10-05 8
2020-10-06 1
2020-10-07 5
2020-10-08 6
2020-10-09 2
2020-10-10 2
2020-10-11 2
2020-10-13 4
2020-10-14 6
2020-10-15 4
2020-10-16 3
2020-10-17 2
2020-10-18 2
2020-10-19 3
2020-10-20 4
2020-10-21 3
2020-10-22 1
2020-10-23 2
2020-10-26 2
2020-10-30 1
2020-10-31 4
2020-11-02 1
2020-11-04 12
2020-11-05 30
2020-11-06 15
2020-11-07 22
2020-11-08 11
2020-11-09 12
2020-11-10 23
2020-11-11 15
2020-11-12 29
2020-11-13 30
2020-11-14 16
2020-11-16 17
2020-11-17 11
2020-11-18 29
2020-11-19 37
2020-11-20 16
2020-11-21 7
2020-11-25 1

@ghost
Copy link

ghost commented Nov 25, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The high numbers of failures seem to be temporary in the end. My assumption about product code change was probably false.
We might hold this PR back for a few more days to confirm this.

Numbers per day (kusto):

Queued Count
2020-09-26 1
2020-09-27 2
2020-09-28 2
2020-09-29 7
2020-09-30 2
2020-10-01 1
2020-10-02 4
2020-10-03 4
2020-10-04 3
2020-10-05 8
2020-10-06 1
2020-10-07 5
2020-10-08 6
2020-10-09 2
2020-10-10 2
2020-10-11 2
2020-10-13 4
2020-10-14 6
2020-10-15 4
2020-10-16 3
2020-10-17 2
2020-10-18 2
2020-10-19 3
2020-10-20 4
2020-10-21 3
2020-10-22 1
2020-10-23 2
2020-10-26 2
2020-10-30 1
2020-10-31 4
2020-11-02 1
2020-11-04 12
2020-11-05 30
2020-11-06 15
2020-11-07 22
2020-11-08 11
2020-11-09 12
2020-11-10 23
2020-11-11 15
2020-11-12 29
2020-11-13 30
2020-11-14 16
2020-11-16 17
2020-11-17 11
2020-11-18 29
2020-11-19 37
2020-11-20 16
2020-11-21 7
2020-11-25 1
Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ManickaP ManickaP requested a review from a team November 25, 2020 16:54
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephentoub
Copy link
Member

We might hold this PR back for a few more days to confirm this.

We should still disable it until it can be investigated further; it may not be failing as frequently as it was, but it's still failing.

Thanks.

@wfurt
Copy link
Member

wfurt commented Dec 2, 2020

/backport to release/5.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/395324929

@ghost ghost locked as resolved and limited conversation to collaborators Jan 1, 2021
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants