Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 45183 #45307

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix issue 45183 #45307

merged 1 commit into from
Nov 30, 2020

Conversation

briansull
Copy link
Contributor

Preserve the paramAttrs when calling SetGenericParamProps

@briansull
Fix issue 45183
a396e60 
   Preserve the paramAttrs
@briansull briansull linked an issue Nov 29, 2020 that may be closed by this pull request
ilasm doesn't preserve "where T : struct", instead produces "where T : ValueType" #45183
Closed
janvorli
janvorli approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@runfoapp runfoapp bot mentioned this pull request Nov 30, 2020
Closed
@briansull
Copy link
Contributor Author

@BruceForstall PTAL

@BruceForstall
Copy link
Member

Fixes #45183

BruceForstall
BruceForstall approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trigger ilasm round-trip job (https://dev.azure.com/dnceng/public/_build?definitionId=870)

@briansull briansull merged commit 0544301 into dotnet:master Nov 30, 2020
@briansull
Copy link
Contributor Author

/azp help

@briansull
Copy link
Contributor Author

/azp runtime-coreclr ilasm

@briansull
Copy link
Contributor Author

Manual Run for #20201130.1 Fix issue 45183 (#45307)
https://dev.azure.com/dnceng/public/_build/results?buildId=903772&view=results

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli approved these changes

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-ILTools-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ilasm doesn't preserve "where T : struct", instead produces "where T : ValueType"
4 participants
@briansull @BruceForstall @janvorli @Dotnet-GitSync-Bot