Various fixes in Microsoft.NETCore.App packs #45566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shared with the libraries area.
|
cc: @JunTaoLuo |
sdmaclea
approved these changes
Dec 3, 2020
ericstj
reviewed
Dec 4, 2020
| <PlatformManifestFileEntry Include="netstandard.dll" /> | ||
| <PlatformManifestFileEntry Include="WindowsBase.dll" /> | ||
| <PlatformManifestFileEntry Include="Microsoft.VisualBasic.dll" /> | ||
| <PlatformManifestFileEntry Include="System.ComponentModel.DataAnnotations.dll" /> |
There was a problem hiding this comment.
You can actually drive these off https://github.com/dotnet/runtime/blob/master/src/libraries/shims/netfxreference.props
ericstj
approved these changes
Dec 4, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the fallback RID graph in the Microsoft.NETCore.App runtime pack.
Remove extraneous entries from the Microsoft.NETCore.App platform manifest and drive generation of the platform manifest entries for managed libraries from a list that already exists in the libraries portion of the repo.