-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make BinderEventListener not listen to TplEventSource #45570
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux Issue DetailsFix #37132. Note: there is an actual product issue here that is related to a deadlock that can occur from using EventListeners to listen to TplEventSource. I will file a separate issue to track the EventListener deadlock bug. In the meantime, this changes BinderEventListener to not listen for TplEventSource which shouldn't be necessary for these tests (the EventListener doesn't check any payload from TplEventSource).
|
#45571 tracks the EventListener bug. |
As long as it's not needed - which @elinor-fung would know better - LGTM. I don't expect any async/task/parallel info to be needed for loading/binding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @hoyosjs! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fix #37132.
Fix #45088
Note: there is an actual product issue here that is related to a deadlock that can occur from using EventListeners to listen to TplEventSource. I will file a separate issue to track the EventListener deadlock bug.
In the meantime, this changes BinderEventListener to not listen for TplEventSource which shouldn't be necessary for these tests (the EventListener doesn't check any payload from TplEventSource).