Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "netcoreapp" and "netfx" TargetGroup #457

Merged
merged 38 commits into from
Dec 14, 2019
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
2eeecc8
netcoreapp -> netcoreapp5.0 in .sln files
Anipik Dec 2, 2019
9bb38a8
netcoreapp; -> netcoreapp5.0; , netcoreapp- to netcoreapp5.0-
Anipik Dec 2, 2019
cc7489a
netcoreapp- -> netcoreapp5.0 in .csproj
Anipik Dec 2, 2019
b1e889c
'netcoreapp -> 'netcoreapp5.0 in .csproj
Anipik Dec 2, 2019
bd1891f
done with libraries sub folder
Anipik Dec 2, 2019
2f70d3b
missed semicolon
Anipik Dec 2, 2019
66bfc49
minor changes
Anipik Dec 2, 2019
fe33700
netcoreapp -> netcoreapp5.0 in some extra files
Anipik Dec 2, 2019
7831a53
vNext target variable in configurations.props
Anipik Dec 2, 2019
71b9862
netcoreapp => netcoreapp5/0 in some other .props file
Anipik Dec 2, 2019
bb47f23
netcoreapp -> vnext in .csproj
Anipik Dec 2, 2019
9450fb5
making the netcorepap framework switch work
Anipik Dec 3, 2019
eb62bc5
fixing sendToHelix and linux build
Anipik Dec 3, 2019
ff73c41
Merge branch 'master' into vnext
Anipik Dec 3, 2019
e9839b0
TargetFrameworkVNext -> netcoreappCurrent
Anipik Dec 3, 2019
b25e16e
Merge branch 'master' into vnext
Anipik Dec 5, 2019
04f85e3
case correct netcoreappcurrent
Anipik Dec 5, 2019
731d5fb
fixing send to helix zip path
Anipik Dec 5, 2019
41a8482
netfx -> net472 in .sln
Anipik Dec 5, 2019
b0fca9a
netfx; -> net472; in .props
Anipik Dec 5, 2019
94db048
netfx- -> net472- in .props
Anipik Dec 5, 2019
b6a5789
netfx - -> net472- in .csproj
Anipik Dec 5, 2019
10af485
'netfx-> 'net472 in .csproj
Anipik Dec 5, 2019
0f7edf7
netfx -> net472 manual change
Anipik Dec 5, 2019
73b3760
fixing ci build for netfx
Anipik Dec 5, 2019
3f2787b
Not trying to change the global property
Anipik Dec 6, 2019
66bd077
Merge branch 'master' into vnext
Anipik Dec 6, 2019
80e4e24
Fixing build failure due to master changes in net https tests
Anipik Dec 6, 2019
325f614
Merge branch 'master' into vnext
Anipik Dec 9, 2019
1be30cf
adding documentaiton and fixing filtering
Anipik Dec 9, 2019
e5ee4eb
netcoreapp -> netcore5.0 in py file
Anipik Dec 10, 2019
6de62e5
Merge branch 'master' into vnext
Anipik Dec 11, 2019
9d4decb
changing the path to use netcoreapp5.0 version
Anipik Dec 11, 2019
4e7f2ca
feedback and override corefx path corrected in installers
Anipik Dec 11, 2019
5d53653
remaing netcoreapp5.0 changes done
Anipik Dec 13, 2019
b1ca85f
Merge branch 'master' into vnext
Anipik Dec 13, 2019
596aa19
netcoreapp-> netcoreapp5.0 after live builds
Anipik Dec 13, 2019
f040d5c
net472 -> netframeworkcurrent
Anipik Dec 13, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
tell Microsoft.Common.props not to import Directory.Build.props again
-->
<ImportDirectoryBuildProps>false</ImportDirectoryBuildProps>
<NetCoreAppCurrent>netcoreapp5.0</NetCoreAppCurrent>
Anipik marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>

<!--
Expand Down
2 changes: 1 addition & 1 deletion eng/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ foreach ($argument in $PSBoundParameters.Keys)
"buildtests" { if ($build -eq $true) { $arguments += " /p:BuildTests=true" } else { $arguments += " -build /p:BuildTests=only" } }
"test" { $arguments += " -test" }
"configuration" { $configuration = (Get-Culture).TextInfo.ToTitleCase($($PSBoundParameters[$argument])); $arguments += " /p:ConfigurationGroup=$configuration -configuration $configuration" }
"framework" { $arguments += " /p:TargetGroup=$($PSBoundParameters[$argument].ToLowerInvariant())"}
"framework" { if ($PSBoundParameters[$argument].ToLowerInvariant() -eq 'netcoreapp') { $arguments += " /p:TargetGroup=netcoreapp5.0" } else { if ($PSBoundParameters[$argument].ToLowerInvariant() -eq 'netfx') { $arguments += " /p:TargetGroup=net472" } else { $arguments += " /p:TargetGroup=$($PSBoundParameters[$argument].ToLowerInvariant())"}}}
Anipik marked this conversation as resolved.
Show resolved Hide resolved
"os" { $arguments += " /p:OSGroup=$($PSBoundParameters[$argument])" }
"allconfigurations" { $arguments += " /p:BuildAllConfigurations=true" }
"arch" { $arguments += " /p:ArchGroup=$($PSBoundParameters[$argument]) /p:TargetArchitecture=$($PSBoundParameters[$argument])" }
Expand Down
5 changes: 5 additions & 0 deletions eng/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ while [[ $# > 0 ]]; do
;;
-framework|-f)
val="$(echo "$2" | awk '{print tolower($0)}')"
if [ "$val" == "netcoreapp" ]; then
val=netcoreapp5.0
elif [ "$val" == "netfx" ]; then
val=net472
fi
arguments="$arguments /p:TargetGroup=$val"
shift 2
;;
Expand Down
13 changes: 0 additions & 13 deletions eng/configurations/targetgroups.props
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@
<Imports>netcoreapp3.0</Imports>
<CompatibleWith>netstandard2.1</CompatibleWith>
</TargetGroups>
<!-- netcoreapp is an alias for netcoreapp5.0 -->
<TargetGroups Include="netcoreapp">
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
<Imports>$(NetCoreAppCurrent)</Imports>
<CompatibleWith>netstandard2.1</CompatibleWith>
</TargetGroups>
<TargetGroups Include="net45">
<TargetFramework>net45</TargetFramework>
<TargetingPackNugetPackageId>Microsoft.TargetingPack.NETFramework.v4.5</TargetingPackNugetPackageId>
Expand Down Expand Up @@ -157,13 +151,6 @@
<Imports>net471</Imports>
<CompatibleWith>netstandard2.0</CompatibleWith>
</TargetGroups>
<!-- netfx is an alias for net472 -->
<TargetGroups Include="netfx">
<TargetFramework>net472</TargetFramework>
<TargetingPackNugetPackageId>Microsoft.TargetingPack.NETFramework.v4.7.2</TargetingPackNugetPackageId>
<Imports>net472</Imports>
<CompatibleWith>netstandard2.0</CompatibleWith>
</TargetGroups>
<TargetGroups Include="win8">
<TargetFramework>win8</TargetFramework>
<TargetFrameworkIdentifier>Windows</TargetFrameworkIdentifier>
Expand Down
2 changes: 1 addition & 1 deletion eng/helixcorefxtests.proj
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
-->
<Target Name="GetTestAssetManifest" Condition=" '$(UsesHelixSdk)' == 'true' " >
<PropertyGroup>
<_TargetGroup>netcoreapp</_TargetGroup>
<_TargetGroup>netcoreapp5.0</_TargetGroup>
<_AssetManifestPath>$(TestAssetBlobFeedUrl)/corefx-tests/$(MicrosoftPrivateCoreFxNETCoreAppVersion)/$(__BuildOS).$(__BuildArch)/$(_TargetGroup)/corefx-test-assets.xml</_AssetManifestPath>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion eng/packaging.props
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<PackagePlatform Condition="'$(PackagePlatform)' == 'amd64'">x64</PackagePlatform>

<!-- Used by PackageLibs.targets -->
<XmlDocFileRoot>$(NuGetPackageRoot)$(MicrosoftPrivateIntellisensePackage)/$(MicrosoftPrivateIntellisenseVersion)/xmldocs/netcoreapp</XmlDocFileRoot>
<XmlDocFileRoot>$(NuGetPackageRoot)$(MicrosoftPrivateIntellisensePackage)/$(MicrosoftPrivateIntellisenseVersion)/xmldocs/$(NetCoreAppCurrent)</XmlDocFileRoot>
Anipik marked this conversation as resolved.
Show resolved Hide resolved

<!-- By default the packaging targets will package desktop facades as ref,
but we don't use this as we now build partial-reference-facades. -->
Expand Down
2 changes: 1 addition & 1 deletion eng/restore/docs.targets
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
AfterTargets="Restore">

<ItemGroup>
<DocFile Include="$(NuGetPackageRoot)$(MicrosoftPrivateIntellisensePackage)/$(MicrosoftPrivateIntellisenseVersion)/xmldocs/netcoreapp/**/*.xml"/>
<DocFile Include="$(NuGetPackageRoot)$(MicrosoftPrivateIntellisensePackage)/$(MicrosoftPrivateIntellisenseVersion)/xmldocs/netcoreapp5.0/**/*.xml"/>
Anipik marked this conversation as resolved.
Show resolved Hide resolved
<DocFile>
<!-- trim off slash since it differs by platform and we need to do a string compare -->
<LCID>$([System.String]::new('%(RecursiveDir)').TrimEnd('\/'))</LCID>
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tests/dir.common.props
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</PropertyGroup>

<ItemGroup Condition="'$(__SkipFXRestore)' == 'true' AND '$(ReferenceSystemPrivateCoreLib)' != 'true'" >
<Reference Include="$(__LocalCoreFXPath)\artifacts\bin\ref\netcoreapp\*.dll" Private="false" />
<Reference Include="$(__LocalCoreFXPath)\artifacts\bin\ref\$(NetCoreAppCurrent)\*.dll" Private="false" />
</ItemGroup>

</Project>
8 changes: 4 additions & 4 deletions src/libraries/Common/Common.Tests.sln
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ Global
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{C72FD34C-539A-4447-9796-62A229571199}.Debug|Any CPU.ActiveCfg = netcoreapp-Windows_NT-Debug|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Debug|Any CPU.Build.0 = netcoreapp-Windows_NT-Debug|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Release|Any CPU.ActiveCfg = netcoreapp-Windows_NT-Release|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Release|Any CPU.Build.0 = netcoreapp-Windows_NT-Release|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Debug|Any CPU.ActiveCfg = netcoreapp5.0-Windows_NT-Debug|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Debug|Any CPU.Build.0 = netcoreapp5.0-Windows_NT-Debug|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Release|Any CPU.ActiveCfg = netcoreapp5.0-Windows_NT-Release|Any CPU
{C72FD34C-539A-4447-9796-62A229571199}.Release|Any CPU.Build.0 = netcoreapp5.0-Windows_NT-Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/Common.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<CoverageSupported>false</CoverageSupported>
<IncludeRemoteExecutor>true</IncludeRemoteExecutor>
<Configurations>netcoreapp-Unix-Debug;netcoreapp-Unix-Release;netcoreapp-Windows_NT-Debug;netcoreapp-Windows_NT-Release</Configurations>
<Configurations>$(NetCoreAppCurrent)-Unix-Debug;$(NetCoreAppCurrent)-Unix-Release;$(NetCoreAppCurrent)-Windows_NT-Debug;$(NetCoreAppCurrent)-Windows_NT-Release</Configurations>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(CommonTestPath)System\Collections\DictionaryExtensions.cs">
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Common/tests/Configurations.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>
<PropertyGroup>
<BuildConfigurations>
netcoreapp-Unix;
netcoreapp-Windows_NT;
$(NetCoreAppCurrent)-Unix;
$(NetCoreAppCurrent)-Windows_NT;
</BuildConfigurations>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>
<PropertyGroup>
<BuildConfigurations>
netcoreapp;
netfx;
$(NetCoreAppCurrent);
net472;
</BuildConfigurations>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
This assembly is referenced from rid agnostic configurations therefore we can't make it RID specific
and instead use runtime checks.
-->
<Configurations>netcoreapp-Debug;netcoreapp-Release;netfx-Debug;netfx-Release</Configurations>
<Configurations>$(NetCoreAppCurrent)-Debug;$(NetCoreAppCurrent)-Release;net472-Debug;net472-Release</Configurations>
</PropertyGroup>
<ItemGroup>
<Compile Include="System\AdminHelpers.cs" />
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/StaticTestGenerator/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ from part in line.Split(' ')
// Invalid command line arguments.
Console.WriteLine("Usage: <output_directory> <helper_assemblies_directory> <test_assembly_path> <xunit_console_options>");
Console.WriteLine(" Example:");
Console.WriteLine(@" dotnet run d:\tmpoutput d:\repos\corefx\artifacts\bin\testhost\netcoreapp-Windows_NT-Debug-x64\shared\Microsoft.NETCore.App\$(ProductVersion) d:\repos\corefx\artifacts\bin\System.Runtime.Tests\netcoreapp-Windows_NT-Debug\System.Runtime.Tests.dll");
Console.WriteLine(@" dotnet run d:\tmpoutput d:\repos\corefx\artifacts\bin\testhost\netcoreapp5.0-Windows_NT-Debug-x64\shared\Microsoft.NETCore.App\$(ProductVersion) d:\repos\corefx\artifacts\bin\System.Runtime.Tests\netcoreapp5.0-Windows_NT-Debug\System.Runtime.Tests.dll");
testAssemblyPath = string.Empty;
runtimeAssembliesPath = string.Empty;
outputPath = string.Empty;
Expand Down
10 changes: 5 additions & 5 deletions src/libraries/Common/tests/StaticTestGenerator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ From within the utility directory, run the utility with the arguments:

For example:
```
dotnet run d:\output "d:\repos\runtime\artifacts\bin\testhost\netcoreapp-Windows_NT-Debug-x64\shared\Microsoft.NETCore.App\5.0.0" "d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp-Windows_NT-Debug\System.Runtime.Tests.dll"
dotnet run d:\output "d:\repos\runtime\artifacts\bin\testhost\netcoreapp5.0-Windows_NT-Debug-x64\shared\Microsoft.NETCore.App\5.0.0" "d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp5.0-Windows_NT-Debug\System.Runtime.Tests.dll"
```
This will run the tool and result in output written to the console like:
```
3/27/2019 10:55:37 PM | Test assembly path : d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp-Windows_NT-Debug\System.Runtime.Tests.dll
3/27/2019 10:55:37 PM | Helper assemblies path: d:\repos\runtime\artifacts\bin\testhost\netcoreapp-Windows_NT-Debug-x64\shared\Microsoft.NETCore.App\3.0.0\
3/27/2019 10:55:37 PM | Test assembly path : d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp5.0-Windows_NT-Debug\System.Runtime.Tests.dll
3/27/2019 10:55:37 PM | Helper assemblies path: d:\repos\runtime\artifacts\bin\testhost\netcoreapp5.0-Windows_NT-Debug-x64\shared\Microsoft.NETCore.App\3.0.0\
3/27/2019 10:55:37 PM | Output path : d:\output\System.Runtime.Tests\
3/27/2019 10:55:37 PM | Xunit arguments : d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp-Windows_NT-Debug\System.Runtime.Tests.dll -notrait category=nonnetcoreapptests -notrait category=nonwindowstests -notrait category=IgnoreForCI -notrait category=failing -notrait category=OuterLoop
3/27/2019 10:55:37 PM | Xunit arguments : d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp5.0-Windows_NT-Debug\System.Runtime.Tests.dll -notrait category=nonnetcoreapptests -notrait category=nonwindowstests -notrait category=IgnoreForCI -notrait category=failing -notrait category=OuterLoop
3/27/2019 10:55:37 PM |
3/27/2019 10:55:37 PM | Loaded System.Runtime.Tests from d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp-Windows_NT-Debug\System.Runtime.Tests.dll
3/27/2019 10:55:37 PM | Loaded System.Runtime.Tests from d:\repos\runtime\artifacts\bin\System.Runtime.Tests\netcoreapp5.0-Windows_NT-Debug\System.Runtime.Tests.dll
3/27/2019 10:55:37 PM | Found 5322 test methods.
3/27/2019 10:55:38 PM | Found 3469 InlineDatas / 949 MethodDatas across 5322 test methods.
3/27/2019 10:55:38 PM |
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project DefaultTargets="Build">
<PropertyGroup>
<BuildConfigurations>
netcoreapp;
$(NetCoreAppCurrent);
</BuildConfigurations>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<RootNamespace>XmlCoreTest.Common</RootNamespace>
<Configurations>netcoreapp-Debug;netcoreapp-Release</Configurations>
<Configurations>$(NetCoreAppCurrent)-Debug;$(NetCoreAppCurrent)-Release</Configurations>
</PropertyGroup>
<ItemGroup>
<Compile Include="AsyncUtil.cs" />
Expand Down
23 changes: 13 additions & 10 deletions src/libraries/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

See Documentation/coding-guidelines/project-guidelines.md for more details on our configurations.
-->
<TargetGroup Condition="'$(TargetGroup)' == ''">netcoreapp</TargetGroup>
<TargetGroup Condition="'$(TargetGroup)' == ''">netcoreapp5.0</TargetGroup>
Anipik marked this conversation as resolved.
Show resolved Hide resolved
<OSGroup Condition="'$(OSGroup)' == ''">$(DefaultOSGroup)</OSGroup>
<ConfigurationGroup Condition="'$(ConfigurationGroup)' == ''">Debug</ConfigurationGroup>
<HostArch>$([System.Runtime.InteropServices.RuntimeInformation]::ProcessArchitecture.ToString().ToLowerInvariant)</HostArch>
Expand All @@ -60,6 +60,9 @@

<!-- Initialize BuildConfiguration from the individual properties if it wasn't already explicitly set -->
<BuildConfiguration Condition="'$(BuildConfiguration)' == ''">$(TargetGroup)-$(OSGroup)-$(ConfigurationGroup)-$(ArchGroup)</BuildConfiguration>
<!-- Versionless netcoreapp and netfx needs to be removed after .yml scripts are finalized.-->
<BuildConfiguration Condition="'$(TargetGroup)' == 'netcoreapp'">netcoreapp5.0-$(OSGroup)-$(ConfigurationGroup)-$(ArchGroup)</BuildConfiguration>
Anipik marked this conversation as resolved.
Show resolved Hide resolved
<BuildConfiguration Condition="'$(TargetGroup)' == 'netfx'">net472-$(OSGroup)-$(ConfigurationGroup)-$(ArchGroup)</BuildConfiguration>

<!-- if PKGPROJ doesn't set BuildConfigurations, make sure it only builds for TargetGroup=package or BuildAllConfigurations -->
<BuildConfigurations Condition="'$(MSBuildProjectExtension)' == '.pkgproj' and '$(BuildConfigurations)' == ''">package</BuildConfigurations>
Expand Down Expand Up @@ -153,8 +156,8 @@

<!-- set properties for each vertical -->
<PropertyGroup>
<BuildingNETCoreAppVertical Condition="'$(BuildingNETCoreAppVertical)' == '' and ('$(_bc_TargetGroup)'=='netcoreapp' or '$(BuildAllConfigurations)' == 'true')">true</BuildingNETCoreAppVertical>
<BuildingNETFxVertical Condition="'$(BuildingNETFxVertical)' == '' and ('$(_bc_TargetGroup)'=='netfx' or '$(BuildAllConfigurations)' == 'true')">true</BuildingNETFxVertical>
<BuildingNETCoreAppVertical Condition="'$(BuildingNETCoreAppVertical)' == '' and ('$(_bc_TargetGroup)'=='$(NetCoreAppCurrent)' or '$(BuildAllConfigurations)' == 'true')">true</BuildingNETCoreAppVertical>
<BuildingNETFxVertical Condition="'$(BuildingNETFxVertical)' == '' and ('$(_bc_TargetGroup)'=='net472' or '$(BuildAllConfigurations)' == 'true')">true</BuildingNETFxVertical>
</PropertyGroup>

<!--
Expand Down Expand Up @@ -253,7 +256,7 @@
<RefPath>$([MSBuild]::NormalizeDirectory('$(RefRootPath)', '$(TargetGroup)'))</RefPath>
<NetStandard20RefPath>$([MSBuild]::NormalizeDirectory('$(RefRootPath)', 'netstandard2.0'))</NetStandard20RefPath>
<NetStandard21RefPath>$([MSBuild]::NormalizeDirectory('$(RefRootPath)', 'netstandard2.1'))</NetStandard21RefPath>
<NetFxRefPath>$([MSBuild]::NormalizeDirectory('$(RefRootPath)', 'netfx'))</NetFxRefPath>
<NetFxRefPath>$([MSBuild]::NormalizeDirectory('$(RefRootPath)', 'net472'))</NetFxRefPath>
<ILAsmToolPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsToolsetDir)', 'ilasm'))</ILAsmToolPath>

<!-- Helix properties -->
Expand All @@ -269,10 +272,10 @@
<RuntimeProjectFile Condition="'$(RuntimeProjectFile)' == ''">$(MSBuildThisFileDirectory)restore\runtime\runtime.depproj</RuntimeProjectFile>

<!-- Paths to binplace package content -->
<NETCoreAppPackageRefPath>$(ArtifactsBinDir)pkg\netcoreapp\ref</NETCoreAppPackageRefPath>
<NETCoreAppPackageRuntimePath>$(ArtifactsBinDir)pkg\netcoreapp\lib</NETCoreAppPackageRuntimePath>
<NetFxPackageRefPath>$(ArtifactsBinDir)pkg\netfx\ref</NetFxPackageRefPath>
<NetFxPackageRuntimePath>$(ArtifactsBinDir)pkg\netfx\lib</NetFxPackageRuntimePath>
<NETCoreAppPackageRefPath>$(ArtifactsBinDir)pkg\$(NetCoreAppCurrent)\ref</NETCoreAppPackageRefPath>
<NETCoreAppPackageRuntimePath>$(ArtifactsBinDir)pkg\$(NetCoreAppCurrent)\lib</NETCoreAppPackageRuntimePath>
<NetFxPackageRefPath>$(ArtifactsBinDir)pkg\net472\ref</NetFxPackageRefPath>
<NetFxPackageRuntimePath>$(ArtifactsBinDir)pkg\net472\lib</NetFxPackageRuntimePath>

<TestHostRootPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'testhost', '$(BuildConfiguration)'))</TestHostRootPath>

Expand Down Expand Up @@ -304,8 +307,8 @@

<PropertyGroup Condition="'$(BuildAllConfigurations)' != 'true'">
<!-- We add extra binplacing for the test shared framework until we can get hardlinking with the runtime directory working on all platforms -->
<BinPlaceTestSharedFramework Condition="'$(_bc_TargetGroup)' == 'netcoreapp'">true</BinPlaceTestSharedFramework>
<BinPlaceNETFXRuntime Condition="'$(_bc_TargetGroup)' == 'netfx'">true</BinPlaceNETFXRuntime>
<BinPlaceTestSharedFramework Condition="'$(_bc_TargetGroup)' == '$(NetCoreAppCurrent)'">true</BinPlaceTestSharedFramework>
<BinPlaceNETFXRuntime Condition="'$(_bc_TargetGroup)' == 'net472'">true</BinPlaceNETFXRuntime>

<NETCoreAppTestSharedFrameworkPath>$([MSBuild]::NormalizeDirectory('$(TestHostRootPath)', 'shared', 'Microsoft.NETCore.App', '$(ProductVersion)'))</NETCoreAppTestSharedFrameworkPath>

Expand Down
8 changes: 4 additions & 4 deletions src/libraries/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<RuntimePath>$(RuntimePath)</RuntimePath>
</BinPlaceConfiguration>
<!-- binplace to directories for packages -->
<BinPlaceConfiguration Condition="'$(IsNETCoreApp)' == 'true' and '$(BuildingNETCoreAppVertical)' == 'true'" Include="netcoreapp-$(_bc_OSGroup)">
<BinPlaceConfiguration Condition="'$(IsNETCoreApp)' == 'true' and '$(BuildingNETCoreAppVertical)' == 'true'" Include="netcoreapp5.0-$(_bc_OSGroup)">
Anipik marked this conversation as resolved.
Show resolved Hide resolved
<PackageFileRefPath Condition="'$(IsNETCoreAppRef)' == 'true'">$(NETCoreAppPackageRefPath)</PackageFileRefPath>
<PackageFileRuntimePath>$(NETCoreAppPackageRuntimePath)</PackageFileRuntimePath>
<RuntimePath Condition="'$(BinPlaceNETCoreAppPackage)' == 'true'">$(NETCoreAppPackageRuntimePath)\..\runtime</RuntimePath>
Expand All @@ -59,10 +59,10 @@
</BinPlaceConfiguration>

<!-- Setup the shared framework directory for testing -->
<BinPlaceConfiguration Condition="'$(BinPlaceTestSharedFramework)' == 'true'" Include="netcoreapp-$(_bc_OSGroup)">
<BinPlaceConfiguration Condition="'$(BinPlaceTestSharedFramework)' == 'true'" Include="netcoreapp5.0-$(_bc_OSGroup)">
<RuntimePath>$(NETCoreAppTestSharedFrameworkPath)</RuntimePath>
</BinPlaceConfiguration>
<BinPlaceConfiguration Condition="'$(BinPlaceNETFXRuntime)' == 'true'" Include="netfx-Windows_NT">
<BinPlaceConfiguration Condition="'$(BinPlaceNETFXRuntime)' == 'true'" Include="net472-Windows_NT">
<RuntimePath>$(TestHostRootPath)</RuntimePath>
</BinPlaceConfiguration>

Expand All @@ -82,7 +82,7 @@
<RefPath>$(RefRootPath)%(Identity)/</RefPath>
</BinPlaceConfiguration>
<!-- for BuildAllConfigurations make sure runtimepaths are created for all vertical targetgroups. -->
<BinPlaceConfiguration Condition="'$(BuildAllConfigurations)' == 'true'" Include="netcoreapp-$(_bc_OSGroup)">
<BinPlaceConfiguration Condition="'$(BuildAllConfigurations)' == 'true'" Include="netcoreapp5.0-$(_bc_OSGroup)">
<RuntimePath>$(ArtifactsBinDir)runtime/%(Identity)-$(ConfigurationGroup)-$(ArchGroup)</RuntimePath>
</BinPlaceConfiguration>

Expand Down
8 changes: 4 additions & 4 deletions src/libraries/Microsoft.CSharp/Microsoft.CSharp.sln
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ Global
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{82B54697-0251-47A1-8546-FC507D0F3B08}.Debug|Any CPU.ActiveCfg = netcoreapp-Debug|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Debug|Any CPU.Build.0 = netcoreapp-Debug|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Release|Any CPU.ActiveCfg = netcoreapp-Release|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Release|Any CPU.Build.0 = netcoreapp-Release|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Debug|Any CPU.ActiveCfg = netcoreapp5.0-Debug|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Debug|Any CPU.Build.0 = netcoreapp5.0-Debug|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Release|Any CPU.ActiveCfg = netcoreapp5.0-Release|Any CPU
{82B54697-0251-47A1-8546-FC507D0F3B08}.Release|Any CPU.Build.0 = netcoreapp5.0-Release|Any CPU
{149D7DFE-2FAC-4A38-89AD-E24CE63AACB8}.Debug|Any CPU.ActiveCfg = netstandard2.0-Debug|Any CPU
{149D7DFE-2FAC-4A38-89AD-E24CE63AACB8}.Debug|Any CPU.Build.0 = netstandard2.0-Debug|Any CPU
{149D7DFE-2FAC-4A38-89AD-E24CE63AACB8}.Release|Any CPU.ActiveCfg = netstandard2.0-Release|Any CPU
Expand Down
Loading