Remove the logic duplication for iOS case #46189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximLipnin
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
Tagging subscribers to this area: @safern, @ViktorHofer Issue DetailsAddresses #46156 (comment)
|
steveisok
approved these changes
Dec 17, 2020
safern
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
LGTM. If you wanted to leave the runonly path outside of TestArchiveTestsRoot you could use an ItemDefinitionGroup to define the common properties for the item group. i.e:
<ItemDefinitionGroup Condition="'$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'tvOS'">
<MyItem>
<SharedMetadata>This is shared</SharedMetadata>
</MyItem>
</ItemDefinitionGroup>
<ItemGroup Condition="'$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'tvOS'">
<MyItem Include="Item1" />
<MyItem Include="Item2">
<SpecificMetadata>MetadataForItem2</SpecificMetadata>
</MyItem>
</ItemGroup>
|
Perhaps, it makes sense to try this variant because the checking for substring looks like a less obvious option here :) |
MaximLipnin
force-pushed
the
ios_helix_cleanup
branch
from
4caf1e2 to
99137e8
Compare
akoeplinger
approved these changes
Dec 18, 2020
|
The |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #46156 (comment)