Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve current directory in init-compiler-and-cmake.cmd #46260

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Dec 20, 2020

No description provided.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas
Copy link
Member Author

jkotas commented Dec 20, 2020

Follow up on #46223 (comment)

-startdir=none is not sufficient to fix this. The current directory is being change by vsvarsall.bat as well. vsvarsall.bat does not take the command line option -startdir=none.

This matches how a few other projects deal with this problem, e.g. https://github.com/Microsoft/php-sdk-binary-tools/blob/master/phpsdk-starter.bat#L6 . I do not have a strong opinion on what we do here.

@ghost
Copy link

ghost commented Dec 20, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: jkotas
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Dec 20, 2020

CI is not triggering on this change for some reason...

eng/native/init-compiler-and-cmake.cmd Outdated Show resolved Hide resolved
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 1a31feb into dotnet:master Dec 21, 2020
@jkotas jkotas deleted the issue-46223 branch December 21, 2020 15:49
@dotnet dotnet deleted a comment from jkotas Dec 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants