Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ilasm Round Trip script by adding retry logic #46765

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Fix Ilasm Round Trip script by adding retry logic #46765

merged 3 commits into from
Jan 12, 2021

Conversation

briansull
Copy link
Contributor

Fixes Issue #44139

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 8, 2021
@briansull
Copy link
Contributor Author

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@briansull
Fix Ilasm Round Trip script by adding retry logic
dcae07b 
Fix bash syntax
Update bash syntax to use while true
@briansull
Copy link
Contributor Author

/azp run runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@briansull
Copy link
Contributor Author

@BruceForstall PTAL

BruceForstall
BruceForstall requested changes Jan 11, 2021
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great with just the one issue

src/tests/Common/CLRTest.Jit.targets
break
fi
echo Trying again
sleep 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like ilasm_count is never incremented.

src/tests/Common/CLRTest.Jit.targets

echo EXECUTION $ilasm_count OF ILASM - FAILED with $ERRORLEVEL

if [ $ilasm_count -eq 3 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be a >= instead of ==? (is that -ge?)

@briansull
Copy link
Contributor Author

Updated with requested fix

@briansull briansull closed this Jan 12, 2021
@briansull briansull reopened this Jan 12, 2021
@briansull briansull merged commit eb03112 into dotnet:master Jan 12, 2021
@briansull briansull deleted the ilasm-roundtrip branch January 12, 2021 20:33
@briansull briansull mentioned this pull request Jan 12, 2021
Closed
This was referenced Jan 12, 2021
Closed
Closed
@briansull briansull mentioned this pull request Feb 8, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@briansull @BruceForstall @Dotnet-GitSync-Bot