Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support profiler activation for same bitness architectures on Windows ARM64 and macOS Apple Silicon #46868

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Support profiler activation for same bitness architectures on Windows ARM64 and macOS Apple Silicon #46868

merged 1 commit into from
Feb 18, 2021

Conversation

ww898
Copy link
Contributor

@ww898 ww898 commented Jan 12, 2021

Please see #39699 for details.

… and x86+arm) on Windows ARM64 and macOS Apple Silicon. #39699
@ghost
Copy link

ghost commented Jan 12, 2021

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Please see #39699 for details.

Author: ww898
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@davmason
Copy link
Member

The change looks good. What testing have you done? I don't think this code path is likely to change much so we shouldn't need to write a test and check it in, but have you at least verified that it behaves as you expect?

@ww898
Copy link
Contributor Author

ww898 commented Jan 30, 2021

Hi @davmason, the pull request is still blocked. Could you please approve it?

@davmason
Copy link
Member

davmason commented Feb 1, 2021

Hi @ww898, I am still waiting on your response to what testing has been done. Have you verified that this works as expected for you?

@davmason
Copy link
Member

davmason commented Feb 7, 2021

Hi @ww898 have you seen my questions above?

@ww898
Copy link
Contributor Author

ww898 commented Feb 7, 2021

Hi @davmason, probably I missed your message. Sorry, it's my fault. I thought the fix is clear and simple enough to be verified in code review. I'll take my M1 and start the pull request verification tomorrow.

@ww898
Copy link
Contributor Author

ww898 commented Feb 18, 2021

Hi @davmason, the fix was tested on real .NET6 runtime ARM64. Could you please merge it?

Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@davmason davmason merged commit dae4d5d into dotnet:master Feb 18, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants