-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support profiler activation for same bitness architectures on Windows ARM64 and macOS Apple Silicon #46868
Support profiler activation for same bitness architectures on Windows ARM64 and macOS Apple Silicon #46868
Conversation
… and x86+arm) on Windows ARM64 and macOS Apple Silicon. #39699
The change looks good. What testing have you done? I don't think this code path is likely to change much so we shouldn't need to write a test and check it in, but have you at least verified that it behaves as you expect? |
Hi @davmason, the pull request is still blocked. Could you please approve it? |
Hi @ww898, I am still waiting on your response to what testing has been done. Have you verified that this works as expected for you? |
Hi @ww898 have you seen my questions above? |
Hi @davmason, probably I missed your message. Sorry, it's my fault. I thought the fix is clear and simple enough to be verified in code review. I'll take my M1 and start the pull request verification tomorrow. |
Hi @davmason, the fix was tested on real .NET6 runtime ARM64. Could you please merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Please see #39699 for details.