Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lots of uint[] allocation in BigInteger #46895

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Fix lots of uint[] allocation in BigInteger #46895

merged 2 commits into from
Jan 14, 2021

Commits on Jan 14, 2021

  1. Fix lots of uint[] allocation in BigInteger 

    - Lots of temporary uint[]s are being created and fed into BigInteger's ctor, which then creates a new one.  This enables using the input in most cases.
- GetPartsForBitManipulation is creating uint[]s for small values, after which it generally gets thrown away.  Stop doing that.
- Stack allocation can be used for smaller values in many cases.
    @stephentoub
    stephentoub committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    798a3a3 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback

    @stephentoub
    stephentoub committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    6f1e900 View commit details
    Browse the repository at this point in the history