Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: let instrumentor decide which blocks to process #47597

Conversation

AndyAyersMS
Copy link
Member

Forthcoming edge-based instrumentation will need to handle some BBF_INTERNAL
blocks, so update main processing logic to accomodate this.

Also have fgInstrument return proper phase status, so we get after-phase
dumping if any instrumentation is added.

Forthcoming edge-based instrumentation will need to handle some BBF_INTERNAL
blocks, so update main processing logic to accomodate this.

Also have `fgInstrument` return proper phase status, so we get after-phase
dumping if any instrumentation is added.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 28, 2021
@AndyAyersMS
Copy link
Member Author

cc @dotnet/jit-contrib -- one "last" refactoring before layering on sparse edge profiling (#46882).

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyAyersMS
Copy link
Member Author

/azp run runtime-jit-experimental

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS
Copy link
Member Author

As with other recent PGO PRs, no unexpected failures in the "jit-experimental" runs.

@AndyAyersMS AndyAyersMS merged commit 42bc286 into dotnet:master Jan 29, 2021
@AndyAyersMS AndyAyersMS deleted the InstrumentorControlsWhatBlocksAreProcessed branch January 29, 2021 01:24
@AndyAyersMS AndyAyersMS mentioned this pull request Feb 6, 2021
54 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants