SPMI: tolerate null pResolvedToken #48208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can see this from `getTailCallHelpers` for indirect calls. Fixes a few recording failures when running coreclr tests under spmi.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@BruceForstall PTAL |
BruceForstall
approved these changes
Feb 12, 2021
| pResolvedToken->cbTypeSpec = (ULONG)tokenOut.cbTypeSpec; | ||
| pResolvedToken->pMethodSpec = (PCCOR_SIGNATURE)buffers->GetBuffer(tokenOut.pMethodSpec_Index); | ||
| pResolvedToken->cbMethodSpec = (ULONG)tokenOut.cbMethodSpec; | ||
| if (pResolvedToken != nullptr) |
There was a problem hiding this comment.
This is only called for resolveToken and tryResolveToken. Can pResolvedToken ever be null for those?
There was a problem hiding this comment.
Probably not? I can try to minimize where we do this, if you think it's important.
There was a problem hiding this comment.
I guess it's not that important.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can see this from
getTailCallHelpersfor indirect calls.Fixes a few recording failures when running coreclr tests under spmi.