Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc PriorityQueue fixes #48539

Merged
merged 8 commits into from
Mar 5, 2021
Merged

Misc PriorityQueue fixes #48539

merged 8 commits into from
Mar 5, 2021

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Feb 20, 2021 •
edited
Loading

Cherry-picked from #48520.

  • Ensure array growth method handles overflow appropriately.
  • Remove redundant allocations in EnqueueRange.
  • Add missing enumerator invalidations.
  • Misc style fixes.

@eiriktsarpalis eiriktsarpalis added this to the 6.0.0 milestone Feb 20, 2021
@eiriktsarpalis eiriktsarpalis self-assigned this Feb 20, 2021
@ghost
Copy link

ghost commented Feb 20, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Cherry-picked from #48520.

  • Ensure array growth method handles overflow appropriately.
  • Remove redundant allocations in EnqueueRange.
  • Misc style fixes.
Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Collections
Milestone: 6.0.0

@eiriktsarpalis
Copy link
Member Author

Hi @stephentoub @layomia, this is ready for review, would you be able to take a look?

Base automatically changed from master to main March 1, 2021 09:08
@eiriktsarpalis
Copy link
Member Author

Hi @stephentoub, would you be able to take another look?

@eiriktsarpalis eiriktsarpalis mentioned this pull request Mar 4, 2021
Merged
@eiriktsarpalis eiriktsarpalis merged commit dc73562 into dotnet:main Mar 5, 2021
@eiriktsarpalis eiriktsarpalis deleted the priorityqueue-fixes branch March 5, 2021 14:13
@DrewScoggins DrewScoggins mentioned this pull request Mar 11, 2021
Open
@DrewScoggins DrewScoggins mentioned this pull request Mar 22, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@layomia layomia Awaiting requested review from layomia

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Collections
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eiriktsarpalis @stephentoub