Revert async nameresolution on Unix #48666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in async lookup (dotnet#47171)" This reverts commit 2f25931.
|
Tagging subscribers to this area: @dotnet/ncl |
SupportsGetAddrInfoAsync is a constant on *nix. Tests check if it's supported and return if not, so unreachable code was created on *nix.
stephentoub
reviewed
Feb 24, 2021
jkotas
approved these changes
Mar 3, 2021
|
@dotnet/ncl Good to merge? |
jkotas
pushed a commit
to dotnet/runtimelab
that referenced
this pull request
Mar 4, 2021
dotnet/runtime#48666 reverts the change that added this dependency.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #48566 (comment)
In short:
getaddrinfo_ais a sub-optimal api, that doesn't perform real async name resolution. Other ways will be explored.This PR undos #34633 and #47171