Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of the pipe #49270

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Reduce the size of the pipe #49270

merged 2 commits into from
Mar 8, 2021

Commits on Mar 7, 2021

  1. Reduce the size of the pipe

    - Use the pipe itself as the synchronization object
    - Store the options instance as a way to reference shared settings
    - Added a field to PipeOptions for storing if the Pool is the ArrayPool implementation of the MemoryPool
    - Shrink PipeAwaitable in the common case
      - Move the ExecutionContext and SynchronizationContext into a typed called the SchedulingContext. These types are mostly used with async await and it's extremely rare to have to capture any of this state.
    - Shrink the size of PipeCompletion
      - Since completion callbacks are deprecated they are rarely set. We remove the pool and the other fields and just store a list (which should be rarely used now).
    - Reduce the default segment pool size to 4 items = 16K buffered
      - The original size was optimized to avoid pool resizes but we need to balance idle memory and the potential resize cost of the resize.
    davidfowl committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    7a196dc View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. PR feedback, fixed build

    davidfowl committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    3de20c8 View commit details
    Browse the repository at this point in the history