Set default features flags to match to iOS SDK defaults #49635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsContributes to #43865.
|
ViktorHofer
reviewed
Mar 15, 2021
MaximLipnin
force-pushed
the
add_ios_default_feature_flags
branch
from
753835e
to
fb5ca4f
Compare
safern
reviewed
Mar 16, 2021
safern
reviewed
Mar 17, 2021
marek-safar
reviewed
Mar 18, 2021
MaximLipnin
force-pushed
the
add_ios_default_feature_flags
branch
3 times, most recently
from
ae6b1b4
to
02e24a1
Compare
steveisok
approved these changes
Mar 22, 2021
This was referenced Mar 22, 2021
… turned off by default.
MaximLipnin
force-pushed
the
add_ios_default_feature_flags
branch
from
bd7a660
to
db62e3a
Compare
akoeplinger
requested changes
Mar 23, 2021
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
akoeplinger
approved these changes
Mar 23, 2021
safern
approved these changes
Mar 24, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #43865.
Based on https://github.com/xamarin/xamarin-macios/blob/834b0888853210ca01d5e8f5ce2c65fe9c55fc10/dotnet/targets/Xamarin.Shared.Sdk.targets#L138-L146
The changes: