Mark some S.S.C.Algorithms APIs as unsupported on ios/tvos #49762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks |
bartonjs
reviewed
Mar 17, 2021
src/libraries/Common/src/System/Security/Cryptography/ECDiffieHellmanSecurityTransforms.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 17, 2021
...raphy.X509Certificates/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Outdated
Show resolved
Hide resolved
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
2 times, most recently
from
3d459d1 to
cd4e553
Compare
bartonjs
reviewed
Mar 19, 2021
...s/System.Security.Cryptography.Algorithms/src/System.Security.Cryptography.Algorithms.csproj
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 19, 2021
...s/System.Security.Cryptography.Algorithms/src/System.Security.Cryptography.Algorithms.csproj
Outdated
Show resolved
Hide resolved
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
4 times, most recently
from
6a77a33 to
c64f827
Compare
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
from
c64f827 to
a5b2bfa
Compare
bartonjs
reviewed
Mar 24, 2021
...s/System.Security.Cryptography.Algorithms/src/System.Security.Cryptography.Algorithms.csproj
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 24, 2021
...ryptography.X509Certificates/src/Internal/Cryptography/Pal.OSX/AppleCertificatePal.Pkcs12.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 24, 2021
...m.Security.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.OSX/CertificatePal.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Mar 24, 2021
...raphy.X509Certificates/src/System/Security/Cryptography/X509Certificates/X509Certificate2.cs
Outdated
Show resolved
Hide resolved
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
from
a5b2bfa to
8b3fafd
Compare
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
from
c632c47 to
9f08ef2
Compare
This was referenced Mar 26, 2021
steveisok
reviewed
Mar 29, 2021
src/libraries/Common/src/System/Security/Cryptography/EccSecurityTransforms.cs
Show resolved
Hide resolved
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
3 times, most recently
from
bee5bac to
e714512
Compare
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
from
e714512 to
2461b34
Compare
…ive_SecKeychainCreate, AppleCryptoNative_SecKeychainDelete, and AppleCryptoNative_SetKeychainNeverLock
…tOaep, AppleCryptoNative_RsaEncryptPkcs, AppleCryptoNative_RsaDecryptOaep, and AppleCryptoNative_RsaDecryptPkcs
…nerateSignature, AppleCryptoNative_GenerateSignatureWithHashAlgorithm, AppleCryptoNative_VerifySignature, AppleCryptoNative_VerifySignatureWithHashAlgorithm, and AppleCryptoNative_SecKeyExport
…d calls in non-public types
…ityTransforms) methods as unsupported
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
2 times, most recently
from
ce89593 to
86c8865
Compare
…ted API (ExportParameters method)
MaximLipnin
force-pushed
the
mark_SSCA_apis_as_unsupported_on_ios_tvos
branch
from
86c8865 to
2777fe2
Compare
|
Looks like some of these APIs will actually work after @filipnavara's #51620 so we should wait for that to land and then update this one. |
|
Please hold on with this. I have pretty much the whole S.S.C.Algorithms working on iOS (main...filipnavara:ios-crypto-003) and I'll clean it up and start submitting as individual PRs for review. |
|
The respective S.S.C.Algorithms APIs were enabled in other PR so this work is no longer needed and I'm closing it. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47910
The affected APIs :
I tried re-enabling some native part (e.g. RSA operations) but it seems to be more time consuming/ requiring more experience and outside of the bound of the current task for annotating.
I had to use warning suppression in managed code (mostly in private/internal classes/methods) where the unsupported APIs are invoked in order to fix the build.
Also, I excluded the unsupported methods from the build on iOS/tvOS by adding
Interop.*.Mobile.csfiles.