[Wasm][AOT] Add the ability to the display the native stack frames

[thaystg]

Another approach for PR #45124

How it will be visible in console:

[ghost]

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Another approach for PR #45124

How it will be visible in console:

Author:	thaystg
Assignees:	-
Labels:	area-VM-meta-mono
Milestone:	-

[radical]

Just wondering if we should make mono_runtime_printf* use logger functions (at least on wasm?), so they will all end up with traces in the js console?

[thaystg]

mono_runtime_printf* already prints in the js console.

[radical]

mono_runtime_printf* already prints in the js console.

oh, then why the change to use g_printerr in case of wasm? If we want it to show up as an error, then maybe mono_runtime_printf_err?

[thaystg]

Because I want to be able to show the callstack when click on the arrow and not only a message.

[radical]

Oh, sorry, I meant, show up in the js console with a trace. I guess, console.error would do that.

And mono_runtime_printf_err doesn't do that? Maybe that needs to be changed? console.error would give you the stack trace with it, right?

[thaystg]

I didn't test mono_runtime_printf_err, if it work I would have to do the same ifdef but instead of using g_printerr
I would use mono_runtime_printf_err. I can test you you think this is important for this PR. :)

[radical]

I didn't test mono_runtime_printf_err, if it work I would have to do the same ifdef but instead of using g_printerr
I would use mono_runtime_printf_err. I can test you you think this is important for this PR. :)

I'm not insisting on anything! I was just thinking that if mono_runtime_printf_err would be changed to use the logger, thus writing with console.error, and showing up in the console with a stack trace, then all other instances of mono_runtime_printf_err callers would get the same benefit. Just a thought :)

[thaystg]

@radical I will test right now.

[radical]

... if it work I would have to do the same ifdef but instead of using g_printerr
I would use mono_runtime_printf_err...

Oh, and I meant replacing the current mono_runtime_printf with mono_runtime_printf_err, and no ifdef in this location. Sorry, I missed mentioning that!

[thaystg]

Then I would change the behavior in the case of non wasm, I'm not sure if we want it...

[radical]

Then I would change the behavior in the case of non wasm, I'm not sure if we want it...

True, and that was my question.. if changing that behavior makes sense. If it doesn't, then this change looks fine. Sorry, for being so confusing 😬

[thaystg]

Yes, mono_runtime_printf_err, shows the stack trace in js console.

[radical]

Ok. So, this message itself is just a debug message, but IIUC, on wasm:

• mono_runtime_printf - doesn't show this with a trace
• mono_runtime_printf_err - does

.. but since the message is just meant as debug message, we wouldn't want to use mono_runtime_printf_err.

So, your current change looks good to me! 👍

[lewing]

LGTM. My only question is if there is a reason we want to preserve the existing behavior on other platforms or was this a bit arbitrary to begin with?

cc @lambdageek @CoffeeFlux