-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casing of compile items in System.Speech and add CI protection #50102
Conversation
jobParameters: | ||
nameSuffix: Libraries_AllConfigurations | ||
buildArgs: -subset libs -allconfigurations | ||
timeoutInMinutes: 90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is desirable, but any idea what it'll do to pressure on CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this skips building runtimes, hosts and other components that are built in the other dev-innerloop legs, this job won't stand out and take more time than the others. From an overall resources perspective, this adds one more job to the already 150+ existing jobs that run per PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove the mono legs from dev-inner loop? I know they protect the specific runtime flavor scenario, but these were added before the mobile legs existed which build that way, so maybe those are enough to protect that scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephentoub just got the build numbers: 25m for the allconfigurations job (vs 50+ min for the other jobs in that pipeline).
Maybe we can remove the mono legs from dev-inner loop? I know they protect the specific runtime flavor scenario, but these were added before the mobile legs existed which build that way, so maybe those are enough to protect that scenario?
@safern sounds great. Do you wanna file an issue for that / work on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed: #50110
Co-authored-by: Dan Moseley <danmose@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for protecting not just fixing!
Hello @ViktorHofer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsFixes #50060
|
Failure is #48441 |
Fixes #50060