Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of compile items in System.Speech and add CI protection #50102

Merged
merged 4 commits into from
Mar 23, 2021

Conversation

ViktorHofer
Copy link
Member

Fixes #50060

jobParameters:
nameSuffix: Libraries_AllConfigurations
buildArgs: -subset libs -allconfigurations
timeoutInMinutes: 90
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is desirable, but any idea what it'll do to pressure on CI?

Copy link
Member Author

@ViktorHofer ViktorHofer Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this skips building runtimes, hosts and other components that are built in the other dev-innerloop legs, this job won't stand out and take more time than the others. From an overall resources perspective, this adds one more job to the already 150+ existing jobs that run per PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove the mono legs from dev-inner loop? I know they protect the specific runtime flavor scenario, but these were added before the mobile legs existed which build that way, so maybe those are enough to protect that scenario?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub just got the build numbers: 25m for the allconfigurations job (vs 50+ min for the other jobs in that pipeline).

Maybe we can remove the mono legs from dev-inner loop? I know they protect the specific runtime flavor scenario, but these were added before the mobile legs existed which build that way, so maybe those are enough to protect that scenario?

@safern sounds great. Do you wanna file an issue for that / work on that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed: #50110

Co-authored-by: Dan Moseley <danmose@microsoft.com>
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for protecting not just fixing!

@ghost
Copy link

ghost commented Mar 23, 2021

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Mar 23, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50060

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, area-System.Speech, auto-merge

Milestone: -

@ViktorHofer ViktorHofer added the enhancement Product code improvement that does NOT require public API changes/additions label Mar 23, 2021
@ViktorHofer
Copy link
Member Author

Failure is #48441

@ViktorHofer ViktorHofer merged commit 4c2f931 into main Mar 23, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-speech-compile-allconfig branch March 23, 2021 20:12
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with allConfigurations on Linux fails on System.Speech
6 participants